Fix -0.0 serialization for implicit-presence float and double fields#1443
Merged
timostamm merged 3 commits intoJun 22, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
emcfarlane
approved these changes
Jun 22, 2026
…lization-for-implicit-presence-float-and-double-fields
…lization-for-implicit-presence-float-and-double-fields
timostamm
deleted the
tstamm/Fix--0.0-serialization-for-implicit-presence-float-and-double-fields
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With implicit presence (the proto3 default for singular scalar fields), the value decides whether a field is serialized:
false,"", and0are considered not set, and are omitted from the wire.But there is a special case for float and double fields. The proto3 spec on Default Field Values:
We missed this detail.
isScalarZeroValuefrom@bufbuild/protobuf/reflecttreats-0.0as a zero value, so a singular float or double field set to-0.0is omitted during serialization, losing its sign in a round-trip.This fixes the behavior to align with the spec. Note that this is a behavior change:
-0.0in a singular implicit-presence field is now written to the wire instead of omitted. The functionequalsinherits the fixed behavior for field presence, but float and double values are still compared with IEEE semantics:NaNdoes not equalNaN, and-0equals0.